[pony-build] Test Fixed

[Fatima Cherkaoui]

Hello Titus,

What I've done to test was :
*
# forcibly check out revision 7 instead of revision 1.
        (ret, out, err) = _run_command(['hg', 'checkout', '7'],
                                       cwd='pony-build-hg-test')
*Then I checked for the existence of new files.

In Hg clone all branches are automatically cloned and it points to the
default branch .
We could allow the hgClone to clone  and point to a different branch from
the beginning but I don't think it will be very useful so I guess will have
to refactor.

Also , when I run the test_qx_web test , I get this error for all tests.
*
Fatima at FATIMA-PC /c/Python26/pony-build/pony_build/tests (f_master)
$ nosetests test_qx_web.py
EEEEE
======================================================================
ERROR: pony_build.tests.test_qx_web.test_index
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\Python26\lib\site-packages\nose-0.11.3-py2.6.egg\nose\case.py",
line
186, in runTest
    self.test(*self.arg)
  File "C:\Python26\pony-build\pony_build\tests\test_qx_web.py", line 80, in
tes
t_index
    go(testutil._server_url)
  File "C:\Python26\lib\site-packages\twill\commands.py", line 112, in go
    browser.go(url)
  File "C:\Python26\lib\site-packages\twill\browser.py", line 122, in go
    raise BrowserStateError("cannot go to '%s'" % (url,))
BrowserStateError: cannot go to 'http://localhost:8912/'*

I have tried changing  the server url  "
http://lyorn.idyll.org/ctb/pb-dev/p/test-expire/" just to check but I don't
think it's the best way to do it . Could you help with this.

Thanks,

Fatima





On Sat, Apr 17, 2010 at 5:33 PM, C. Titus Brown <ctb at msu.edu> wrote:

> On Wed, Apr 07, 2010 at 09:50:38PM -0500, Fatima Cherkaoui wrote:
> > I have created a new branch as advised called f_master . I fixed the
> hg_test
> > and pushed it to the same branch:
> >
> >
> http://github.com/cherkf/pony-build/blob/f_master/client/test_client/test_hg_client.py
> >
> > Could you take a look at it and advise what I should work on next.
>
> Hi Fatima,
>
> I grabbed it, merged in all of my changes, and ran the tests -- so far
> so good!  Please grab my updated master branch and make changes to that;
> you should be able to do a 'pull' into your f_master branch, if you like.
>
> Comments:
>
> --
>
> On line 97 of test_hg_client,
>
>
> http://github.com/cherkf/pony-build/blob/f_master/client/test_client/test_hg_client.py#L97
>
> you should change the URL so that it's not hardcoded.
>
> There are also some lines commented out in here that should just be removed
> ('commands.getoutput', etc.)
>
> --
>
> I don't see how this is actually testing the 'branch' argument to HgClone,
> though, since you don't ever call HgClone with branch set to anything
> other than default.  Could you remind me of your ultimate decision on
> things?
>
> If allowing multiple branches in HgClone doesn't make sense, then please
> go ahead and refactor HgClone so that all of that code is removed.
>
> If it *does* make sense, then your tests should test it :)
>
> --
>
> Should I also look at your 'mkdir' branch?
>
> thanks,
> --titus
> --
> C. Titus Brown, ctb at msu.edu
>



-- 

Fatima-Zohra Cherkaoui

Activity Chair of Society of Women Engineers
Minnesota State University,Mankato



-- 

Fatima-Zohra Cherkaoui

Activity Chair of Society of Women Engineers
Minnesota State University,Mankato
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.idyll.org/pipermail/pony-build/attachments/20100417/526714a0/attachment.htm>