<div class="gmail_quote">Hello Titus, <br><br>What I've done to test was : <br><b><br># forcibly check out revision 7 instead of revision 1.<br> (ret, out, err) = _run_command(['hg', 'checkout', '7'],<br>
cwd='pony-build-hg-test')<br>
</b>Then I checked for the existence of new files. <br><br>In Hg clone all branches are automatically cloned and it points to the default branch . <br>We could allow the hgClone to clone and point to a different branch from the beginning but I don't think it will be very useful so I guess will have to refactor. <br>
<br>Also , when I run the test_qx_web test , I get this error for all tests. <br><b><br>Fatima@FATIMA-PC /c/Python26/pony-build/pony_build/tests (f_master)<br>$ nosetests test_qx_web.py<br>EEEEE<br>======================================================================<br>
ERROR: pony_build.tests.test_qx_web.test_index<br>----------------------------------------------------------------------<br>Traceback (most recent call last):<br> File "C:\Python26\lib\site-packages\nose-0.11.3-py2.6.egg\nose\case.py", line<br>
186, in runTest<br> self.test(*self.arg)<br> File "C:\Python26\pony-build\pony_build\tests\test_qx_web.py", line 80, in tes<br>t_index<br> go(testutil._server_url)<br> File "C:\Python26\lib\site-packages\twill\commands.py", line 112, in go<br>
browser.go(url)<br> File "C:\Python26\lib\site-packages\twill\browser.py", line 122, in go<br> raise BrowserStateError("cannot go to '%s'" % (url,))<br>BrowserStateError: cannot go to '<a href="http://localhost:8912/" target="_blank">http://localhost:8912/</a>'</b><br>
<br>I have tried changing the server url "<a href="http://lyorn.idyll.org/ctb/pb-dev/p/test-expire/" target="_blank">http://lyorn.idyll.org/ctb/pb-dev/p/test-expire/</a>" just to check but I don't think it's the best way to do it . Could you help with this. <br>
<br>Thanks, <br><br>Fatima<div><div></div><div class="h5"><br clear="all"><br><br><br><br><div class="gmail_quote">On Sat, Apr 17, 2010 at 5:33 PM, C. Titus Brown <span dir="ltr"><<a href="mailto:ctb@msu.edu" target="_blank">ctb@msu.edu</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div>On Wed, Apr 07, 2010 at 09:50:38PM -0500, Fatima Cherkaoui wrote:<br>
</div><div>> I have created a new branch as advised called f_master . I fixed the hg_test<br>
> and pushed it to the same branch:<br>
><br>
> <a href="http://github.com/cherkf/pony-build/blob/f_master/client/test_client/test_hg_client.py" target="_blank">http://github.com/cherkf/pony-build/blob/f_master/client/test_client/test_hg_client.py</a><br>
><br>
> Could you take a look at it and advise what I should work on next.<br>
<br>
</div>Hi Fatima,<br>
<br>
I grabbed it, merged in all of my changes, and ran the tests -- so far<br>
so good! Please grab my updated master branch and make changes to that;<br>
you should be able to do a 'pull' into your f_master branch, if you like.<br>
<br>
Comments:<br>
<br>
--<br>
<br>
On line 97 of test_hg_client,<br>
<br>
<a href="http://github.com/cherkf/pony-build/blob/f_master/client/test_client/test_hg_client.py#L97" target="_blank">http://github.com/cherkf/pony-build/blob/f_master/client/test_client/test_hg_client.py#L97</a><br>
<br>
you should change the URL so that it's not hardcoded.<br>
<br>
There are also some lines commented out in here that should just be removed<br>
('commands.getoutput', etc.)<br>
<br>
--<br>
<br>
I don't see how this is actually testing the 'branch' argument to HgClone,<br>
though, since you don't ever call HgClone with branch set to anything<br>
other than default. Could you remind me of your ultimate decision on things?<br>
<br>
If allowing multiple branches in HgClone doesn't make sense, then please<br>
go ahead and refactor HgClone so that all of that code is removed.<br>
<br>
If it *does* make sense, then your tests should test it :)<br>
<font color="#888888"><br>
--<br>
<br>
Should I also look at your 'mkdir' branch?<br>
<br>
thanks,<br>
</font><div><div></div><div>--titus<br>
--<br>
C. Titus Brown, <a href="mailto:ctb@msu.edu" target="_blank">ctb@msu.edu</a><br>
</div></div></blockquote></div><br><br clear="all"><br></div></div><font color="#888888">-- <br><br>Fatima-Zohra Cherkaoui<br><br>Activity Chair of Society of Women Engineers<br>Minnesota State University,Mankato<br>
</font></div><br><br clear="all"><br>-- <br><br>Fatima-Zohra Cherkaoui<br><br>Activity Chair of Society of Women Engineers<br>Minnesota State University,Mankato<br>