[twill] query_string handling in wsgi_intercept.py

Titus Brown titus at caltech.edu
Wed Apr 16 17:46:32 PDT 2008


On Wed, Apr 16, 2008 at 12:42:46PM -0500, Kumar McMillan wrote:
-> On Wed, Apr 16, 2008 at 3:06 AM, Titus Brown <titus at caltech.edu> wrote:
-> >  -> In short, query string is decoded twice like following
-> >  -> %2B -> + -> SPACE
-> >  ->
-> >  -> Please look into the attached file. This change doesn't break the
-> >  -> twill's unittest at all.
-> >
-> >  Hi Takashi, thanks -- I have to look into this more, but I have little
-> >  doubt your patch fixes a real problem :).
-> >
-> >  I should also check with Kumar to see if his latest version of
-> >  wsgi_intercept handles this properly...
-> 
-> funny, Juergen Karnaller just reported this bug a few days ago:
-> http://code.google.com/p/wsgi-intercept/issues/detail?id=11
-> 
-> I take it no one can think of why unquoting was done here?  Otherwise
-> I'll go ahead and remove it and cut a bugfix release.

Is "Titus is a butthead and didn't test the code" an acceptable
reason? :)

--titus



More information about the twill mailing list