<div dir="ltr"><div>Hi Ian,<br><br>Thanks for your response. That's what I thought too. What you said makes sense and using an AST tree would probably end up finding some assert statement down the road (or if not, flag the test).<br><br></div><div>Such tool would definitely be handy test linting tool. I'll look around pypi otherwise I may take a stab at implementing it depending on my spare bandwidth.<br><br></div><div>Best,<br></div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">2014-11-14 10:51 GMT-08:00 Ian Cordasco <span dir="ltr"><<a href="mailto:graffatcolmingov@gmail.com" target="_blank">graffatcolmingov@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On Fri, Nov 14, 2014 at 12:00 PM, Alexandre Conrad<br>
<<a href="mailto:alexandre.conrad@gmail.com">alexandre.conrad@gmail.com</a>> wrote:<br>
> Hi list,<br>
><br>
> I was wondering if you knew a tool that would ensure that tests contain some<br>
> kind of assertions e.g., an assert statement or a call to a method such as<br>
> TestCase.assertTrue().<br>
><br>
> I would love to be able to run something like "py.test<br>
> --fail-missing-assert" which would fail a test if the user accidentally did<br>
> "data == expected_data" rather than "assert data == expected_data".<br>
><br>
> Tests without any assertions are the worst because the number of tests and<br>
> code coverage grows providing a false sense of satisfaction when really the<br>
> test would have failed in the first place if a proper assertion was written.<br>
><br>
> Any thoughts on this?<br>
><br>
> Thanks,<br>
> --<br>
> Alex<br>
><br>
</div></div>> _______________________________________________<br>
> testing-in-python mailing list<br>
> <a href="mailto:testing-in-python@lists.idyll.org">testing-in-python@lists.idyll.org</a><br>
> <a href="http://lists.idyll.org/listinfo/testing-in-python" target="_blank">http://lists.idyll.org/listinfo/testing-in-python</a><br>
><br>
<br>
Hey Alex,<br>
<br>
I don't know how practical this would be. You'd essentially have to do<br>
a whole other pass over the code (either using static or AST analysis)<br>
to determine if an assertion wasn't made. The reason for this is that<br>
a lot of test suites write helper methods to try to DRY up their tests<br>
so a test may end with self.verifyFooBarBaz(some, params) which calls<br>
another method. Static analysis as a first pass would flag that test<br>
method, but using the AST you might be able to find the assertion...<br>
eventually.<br>
<br>
Cheers,<br>
Ian<br>
</blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature"><div dir="ltr">Alex</div></div>
</div>