<div dir="ltr"><div class="gmail_extra">Hi,<br><br></div><div class="gmail_extra"><div class="gmail_quote">On Wed, Mar 5, 2014 at 3:32 AM, Ned Batchelder <span dir="ltr"><<a href="mailto:ned@nedbatchelder.com" target="_blank">ned@nedbatchelder.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="adM"><div class=""><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">
<div>The pypi version is broken as well! I realise I should
have made that more explicit in my last email - sorry
about that.<br>
<br>
</div>
<div>The gist I linked to earlier creates a virtualenv and
grabs two versions from pypi: one that works, one that
does not. The conversation about bundling js files (or
not) is a good one to have, but the bug is present in the
'upstream' version on pypi as well.<br>
</div>
<div><br>
</div>
</div>
</div>
</div>
</blockquote></div></div>
I'm trying to understand what has changed to make the behavior
change. Something in Trusty? Does anyone else have Trusty
installed that can test the behavior?</blockquote></div><br><br></div><div class="gmail_extra">As discussed on IRC, the root problem here twofold:<br><br><ol><li>coverage, when copying static files to the html report dir will look in the system path (/usr/share/javascript) for the files it wants, and will prefer those files over the ones it bundles locally.</li>
<li>The jquery-hotkeys JS files that are shipped in trusty have changed, and are no longer compatible with coverage.</li></ol><p><br></p><p>It seems like the options to fix this are:</p><ul><li>Make coverage use it's locally bundled files always. I.e.- _never_ look in /usr/share/javascript<br>
</li><li>Make coverage use it's locally bundled jquery.hotkeys.js file always. i.e.- continue to use /usr/share/javascript for other .js files, but _never_ for jquery.hotkeys.js<br></li><li>Try and roll back the jquery.hotkeys changes in trusty.<br>
</li></ul></div><div class="gmail_extra"><br></div><div class="gmail_extra">The first two would fix the problem for users grabbing coverage from pypi, but we'd need to remove the distro-patch from the Ubuntu packages (but I can take care of that). The third option is a bit more dicey - I'm not convinced that the package is outright broken, merely incompatible with coverage.<br>
<br></div><div class="gmail_extra">Let me know which solution you prefer, and I'll see if I can fix things up.<br><br></div><div class="gmail_extra">Cheers,<br clear="all"></div><div class="gmail_extra"><br>-- <br><div dir="ltr">
<div>Thomi Richards<br></div><a href="mailto:thomi.richards@canonical.com" target="_blank">thomi.richards@canonical.com</a><br></div>
</div></div>