<div dir="ltr"><br><br><div class="gmail_quote">---------- Forwarded message ----------<br>From: <b class="gmail_sendername">Olemis Lang</b> <span dir="ltr"><<a href="mailto:olemis@gmail.com">olemis@gmail.com</a>></span><br>
Date: Fri, Feb 28, 2014 at 4:20 PM<br>Subject: Re: [TIP] Fwd: Advice on location of tests modules<br>To: John Wong <<a href="mailto:gokoproject@gmail.com">gokoproject@gmail.com</a>><br><br><br><div dir="ltr"><br><div class="gmail_extra">
<br><br><div class="gmail_quote"><div class="">On Thu, Feb 27, 2014 at 7:30 PM, John Wong <span dir="ltr"><<a href="mailto:gokoproject@gmail.com" target="_blank">gokoproject@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br>On Thu, Feb 27, 2014 at 6:51 PM, Olemis Lang <span dir="ltr"><<a href="mailto:olemis@gmail.com" target="_blank">olemis@gmail.com</a>></span> wrote<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div><div><div dir="ltr"><div class="gmail_quote"><div dir="ltr"><div class="gmail_quote"><div><div><br></div><div>The structure is like this </div><div><br></div><div>+ /trunk</div><div>| +-- bloodhound_dashboard</div>
<div>| | +-- setup.py</div><div>| | +-- bhdashboard</div>
<div>| | +-- ... plugin source code with sub packages ...</div><div>| | +-- tests</div><div>| | +--- ... test code ...</div></div><div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div dir="ltr"><div><div>I believe this means tests is also included in the package installation (when you run setup.py)<br>
</div></div></div></blockquote><div><br></div></div><div><div>no, afaict
those folders are ignored in setup.py pkg defintion . For multiproduct
module the separation is more obvious . Harder to see for trac source
tree .</div>
<div><div> </div></div></div></div></div></div></div></div></div></blockquote><div><br></div>I know this is not the right place to discuss this, but are you sure? I just cloned and did a test.<br><br>>>> from bhdashboard.tests import test_report<br>
</div></div></blockquote><div><br></div></div><div>I thought you were referring to bdist_* packages ... </div><div class=""><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">
<div class="gmail_extra">
In fact, bloodhound_multiproduct is the only package that has tests/ next to setup.py. I think all the points you in comment 3 (<a href="https://issues.apache.org/bloodhound/ticket/770#comment:3" target="_blank">https://issues.apache.org/bloodhound/ticket/770#comment:3</a>) are valid.<br>
<br></div><div class="gmail_extra">To back up your argument: see <a href="http://www.ianbicking.org/docs/setuptools-presentation/" target="_blank">http://www.ianbicking.org/docs/setuptools-presentation/</a> slide 20 though.<br>
</div><div class="gmail_extra">
<br></div></div></blockquote><div><br></div></div><div>ok , thanks .</div><div> </div><div>[...] </div><div class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">
<div class="gmail_extra">
<br></div><div class="gmail_extra">So why would anyone choose to make tests a subpackage?<br>
</div><div class="gmail_extra">setuptools provides another command called tests (python setup.py tests). See <a href="http://stackoverflow.com/questions/4734292/specifying-where-to-install-tests-require-dependecies-of-a-distribute-setuptoo" target="_blank">http://stackoverflow.com/questions/4734292/specifying-where-to-install-tests-require-dependecies-of-a-distribute-setuptoo</a><br>
I can even hook this up with nose and pytest. Therefore, people who choose to make tests a submodule can separate test dependencies from project dependencies. That's probably the #1 defense.<br><br></div></div></blockquote>
<div><br></div></div><div>Yes , I use setuptools test command quite often , and I can even use it with layout (3) in bloodhound_multiproduct plugin by installing source packages (or svn checkout) using setup.py develop cmd ...</div>
<div><br></div><div>[...]</div><span class="HOEnZb"><font color="#888888"><div><br></div><div>-- <br></div></font></span></div><div class="">Regards,<br><br>Olemis - @olemislc<br><br>Apache™ Bloodhound contributor<br><a href="http://issues.apache.org/bloodhound" target="_blank">http://issues.apache.org/bloodhound</a><br>
<a href="http://blood-hound.net" target="_blank">http://blood-hound.net</a><br><br>Blog ES: <a href="http://simelo-es.blogspot.com/" target="_blank">http://simelo-es.blogspot.com/</a><br>Blog EN: <a href="http://simelo-en.blogspot.com/" target="_blank">http://simelo-en.blogspot.com/</a><br>
<br>Featured article:<br><br><br>
</div></div></div>
</div><br><br clear="all"><br>-- <br>Regards,<br><br>Olemis - @olemislc<br><br>Apache™ Bloodhound contributor<br><a href="http://issues.apache.org/bloodhound">http://issues.apache.org/bloodhound</a><br><a href="http://blood-hound.net">http://blood-hound.net</a><br>
<br>Blog ES: <a href="http://simelo-es.blogspot.com/">http://simelo-es.blogspot.com/</a><br>Blog EN: <a href="http://simelo-en.blogspot.com/">http://simelo-en.blogspot.com/</a><br><br>Featured article:<br><br><br>
</div>