<div class="gmail_extra"><div class="gmail_quote">On 21 November 2012 08:47, Michael <span dir="ltr"><<a href="mailto:mock@webhippo.net" target="_blank">mock@webhippo.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I would like to respectfully answer this:<br>
</blockquote><div>It doesn't look like you succeeded in answering respectfully.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> </blockquote><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
This is a super un-useful answer.<br>
<br>
1. Yes it worked in 0.7.2<br>
2. No the docs did not mention the __init__/super was call was required. For all we knew it was not required.<br>
3. The docs also do not mention like all kinds of things, like that one should step on one foot while using mock ... that does not mean we should do them.<br></blockquote><div><br></div><div>That's true; nor does it mention you must have Python installed, or your computer must be switched on. I don</div>
<div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Did Mock's documentation ever tell you not to call the super init?<br>
Generally speaking this is something subclasses need to do in Python, and<br>
not doing it is a latent bug.<br>
<br>
-m<br>
</blockquote>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On 20 November 2012 11:53, Eric Rasmussen <ericrasmussen at <a href="http://gmail.com" target="_blank">gmail.com</a>> wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hello,<br>
<br>
I am upgrading from Mock 0.7 and it looks like there was a backwards<br>
incompatible change in 0.8: it's apparently no longer possible to create a<br>
class inheriting from Mock unless you call the super method. Can someone<br>
explain why the below works in 0.7 but not in 0.8 and above?<br>
<br>
class MyMock(Mock):<br>
def __init__(self, name):<br>
<a href="http://self.name" target="_blank">self.name</a> = name<br>
<br>
Now I have to write:<br>
<br>
class MyMock(Mock):<br>
def __init__(self, name):<br>
Mock.__init__(self)<br>
<a href="http://self.name" target="_blank">self.name</a> = name<br>
<br>
I did find an issue here:<br>
<a href="http://code.google.com/p/mock/issues/detail?id=161" target="_blank">http://code.google.com/p/mock/<u></u>issues/detail?id=161</a><br>
<br>
But it does not mention the reason for the change. I was unable to find<br>
any mention of a backwards incompatible change of this nature in the<br>
changelog, which is concerning. I just want to make sure I fully understand<br>
the scope of the change. If you can point me to any documentation or pull<br>
requests that show when and why this change was made that would be an<br>
enormous help.<br>
<br>
It's really important for a project I'm working on that we document this<br>
new requirement for creating a subclass of Mock, so I appreciate any<br>
insight you can offer.<br>
<br>
Thank you,<br>
Eric<br>
<br>
______________________________<u></u>_________________<br>
testing-in-python mailing list<br>
testing-in-python at <a href="http://lists.idyll.org" target="_blank">lists.idyll.org</a><br>
<a href="http://lists.idyll.org/listinfo/testing-in-python" target="_blank">http://lists.idyll.org/<u></u>listinfo/testing-in-python</a><br>
<br>
<br>
</blockquote>
<br>
<br>
--<br>
Martin<br>
</blockquote>
-------------- next part --------------<br>
An HTML attachment was scrubbed...<br>
URL: <<a href="http://lists.idyll.org/pipermail/testing-in-python/attachments/20121121/0dc24a9d/attachment.html" target="_blank">http://lists.idyll.org/<u></u>pipermail/testing-in-python/<u></u>attachments/20121121/0dc24a9d/<u></u>attachment.html</a>><br>
<br>
<br>
______________________________<u></u>_________________<br>
testing-in-python mailing list<br>
<a href="mailto:testing-in-python@lists.idyll.org" target="_blank">testing-in-python@lists.idyll.<u></u>org</a><br>
<a href="http://lists.idyll.org/listinfo/testing-in-python" target="_blank">http://lists.idyll.org/<u></u>listinfo/testing-in-python</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br>Martin<br><br>
</div>