[pygr-notify] Issue 113 in pygr: pass **kwargs for do_gunzip and run_gunzip (downloader.py)

[codesite-noreply at google.com]

Status: New
Owner: pygr-bug... at googlegroups.com
Labels: Type-Defect Priority-Low

New issue 113 by deepreds: pass **kwargs for do_gunzip and run_gunzip  
(downloader.py)
http://code.google.com/p/pygr/issues/detail?id=113

there are some inconsistency. do_gunzip and run_gunzip are not getting
**kwargs, but uncompress_file function definitely pass **kwargs. Thus,
proposed solution for this is to remove **kwargs or pass **kwargs on
do_gunzip and run_gunzip. It will be a lot easier in terms of automatic
checking of compressed files...


def do_gunzip(filepath,newpath=None):
def run_gunzip(filepath,newpath=None):

     elif filepath.endswith('.gz'):
         logger.info('gunzipping %s...' % filepath)
         try:  # could use gzip module, but it's two times slower!!
             return run_gunzip(filepath, **kwargs) # run as sub process
         except OSError: # on Windows, have to run as python module
             return do_gunzip(filepath, **kwargs)

Now, for seqdb downloading, always pass singleFile=True.

src = SourceURL(newurl, filename = genoname + mytype, singleFile = True)


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings