[pygr-notify] Issue 18 in pygr: minor refactoring of protest.py

[codesite-noreply at google.com]

Issue 18: minor refactoring of protest.py
http://code.google.com/p/pygr/issues/detail?id=18

New issue report by ti... at idyll.org:
 2008 12:54:22 -0700
Subject: [PATCH] nolleyal and titus's minor refactoring of protest.py.

Briefly,

 - switched the os.system call to subprocess, which removes the need to
   use temporary files to store stdout;

 - added stderr capture & replay;

 - added #! /usr/bin/env python at the top to support 'protest.py's
   direct use from the shell;

 - added a docstring at the top of the file;

 - removed space from '.' output to conform to nose's output;

 - cleaned up the main test runner and a few other places for PEP-8.

NOTE that subprocess doesn't exist in Python 2.3, so this axes Python
2.3 compatibility for the tests.  I don't know how important this is, as
every major platform now comes with 2.4 or above; see mailist list
discussion.


Attachments:
	0004-nolleyal-and-titus-s-minor-refactoring-of-protest.py.patch  3.7 KB


Issue attributes:
	Status: New
	Owner: Acracker
	CC: ti... at idyll.org
	Labels: Type-Patch Priority-Medium

-- 
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings