Here you go, forgot to push other day after commit, then forgot to email after push.<br><br><a href="http://github.com/mlaite/pony-build/commit/3dade44fde3f6bd5011898d18e85a3f224771d7c">http://github.com/mlaite/pony-build/commit/3dade44fde3f6bd5011898d18e85a3f224771d7c</a><br>
<br><div class="gmail_quote">On Sun, Apr 25, 2010 at 10:00 PM, C. Titus Brown <span dir="ltr"><<a href="mailto:ctb@msu.edu">ctb@msu.edu</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
would there be an associated push?<br>
<div><div></div><div class="h5"><br>
On Sun, Apr 25, 2010 at 09:54:10PM -0400, Max Laite wrote:<br>
> Ah, try/finally worked out pretty good. I will get this stuff figured out<br>
> eventually, or maybe not. haha<br>
><br>
> Will look at the redundant success loop and push some more changes sometime<br>
> this week.<br>
><br>
> May be a little slow though next couple weeks, got end semester stuff and<br>
> carnival.<br>
><br>
> Thanks!<br>
><br>
> Max<br>
><br>
> On Sun, Apr 25, 2010 at 9:20 PM, C. Titus Brown <<a href="mailto:ctb@msu.edu">ctb@msu.edu</a>> wrote:<br>
><br>
> > On Sat, Apr 24, 2010 at 08:27:02PM -0400, Max Laite wrote:<br>
> > > Whoops, guess I did not.<br>
> > ><br>
> > ><br>
> > <a href="http://github.com/mlaite/pony-build/commit/dbc6e54b65689ca27d71e7c9290ca897e789259a" target="_blank">http://github.com/mlaite/pony-build/commit/dbc6e54b65689ca27d71e7c9290ca897e789259a</a><br>
> > ><br>
> > > Still passes all the context tests. Yay :)<br>
> > ><br>
> > > Though, I think we may have to change up the tests for the c.run()<br>
> > > try/except block a bit to make sure it works as intended. What those<br>
> > changes<br>
> > > are? --I am not sure yet, have to formulate my thoughts I guess.<br>
> > ><br>
> > > Ummmm, yup, that is about it for now.<br>
> ><br>
> > Cool -- let me know when you figure out what changes you want to make :).<br>
> > Looks good, thanks!<br>
> ><br>
> > I also wanted to point out a few things:<br>
> ><br>
> > around<br>
> > <a href="http://github.com/mlaite/pony-build/blob/env/client/pony_client.py#L813" target="_blank">http://github.com/mlaite/pony-build/blob/env/client/pony_client.py#L813</a>,<br>
> ><br>
> > you're violating "Don't Repeat Yourself (DRY)" -- context.end_command() and<br>
> > reslist.append are called both within and without the 'except' (and<br>
> > incidentally, in different orders. tsk tsk.). I think with a teensy bit<br>
> > of refactoring and judicious use of 'try/finally', you could make this<br>
> > a bit shorter and a lot neater.<br>
> ><br>
> > Note that the 'success' for loop (line 829 onwards) is pretty redundant;<br>
> > you can do that same logic within the main command loop, I think.<br>
> ><br>
> > Whaddya say?<br>
> ><br>
> > thanks,<br>
> > --titus<br>
> ><br>
<br>
</div></div><div class="im">> _______________________________________________<br>
> pony-build mailing list<br>
> <a href="mailto:pony-build@lists.idyll.org">pony-build@lists.idyll.org</a><br>
> <a href="http://lists.idyll.org/listinfo/pony-build" target="_blank">http://lists.idyll.org/listinfo/pony-build</a><br>
<br>
<br>
</div>--<br>
<div><div></div><div class="h5">C. Titus Brown, <a href="mailto:ctb@msu.edu">ctb@msu.edu</a><br>
</div></div></blockquote></div><br>