Ah, try/finally worked out pretty good. I will get this stuff figured out eventually, or maybe not. haha<br><br>Will look at the redundant success loop and push some more changes sometime this week.<br><br>May be a little slow though next couple weeks, got end semester stuff and carnival.<br>
<br>Thanks!<br> <br>Max<br><br><div class="gmail_quote">On Sun, Apr 25, 2010 at 9:20 PM, C. Titus Brown <span dir="ltr"><<a href="mailto:ctb@msu.edu">ctb@msu.edu</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div class="im">On Sat, Apr 24, 2010 at 08:27:02PM -0400, Max Laite wrote:<br>
> Whoops, guess I did not.<br>
><br>
> <a href="http://github.com/mlaite/pony-build/commit/dbc6e54b65689ca27d71e7c9290ca897e789259a" target="_blank">http://github.com/mlaite/pony-build/commit/dbc6e54b65689ca27d71e7c9290ca897e789259a</a><br>
><br>
> Still passes all the context tests. Yay :)<br>
><br>
> Though, I think we may have to change up the tests for the c.run()<br>
> try/except block a bit to make sure it works as intended. What those changes<br>
> are? --I am not sure yet, have to formulate my thoughts I guess.<br>
><br>
> Ummmm, yup, that is about it for now.<br>
<br>
</div>Cool -- let me know when you figure out what changes you want to make :).<br>
Looks good, thanks!<br>
<br>
I also wanted to point out a few things:<br>
<br>
around <a href="http://github.com/mlaite/pony-build/blob/env/client/pony_client.py#L813" target="_blank">http://github.com/mlaite/pony-build/blob/env/client/pony_client.py#L813</a>,<br>
<br>
you're violating "Don't Repeat Yourself (DRY)" -- context.end_command() and<br>
reslist.append are called both within and without the 'except' (and<br>
incidentally, in different orders. tsk tsk.). I think with a teensy bit<br>
of refactoring and judicious use of 'try/finally', you could make this<br>
a bit shorter and a lot neater.<br>
<br>
Note that the 'success' for loop (line 829 onwards) is pretty redundant;<br>
you can do that same logic within the main command loop, I think.<br>
<br>
Whaddya say?<br>
<br>
thanks,<br>
<font color="#888888">--titus<br>
</font></blockquote></div><br>