Whoops, guess I did not.<br><br><a href="http://github.com/mlaite/pony-build/commit/dbc6e54b65689ca27d71e7c9290ca897e789259a">http://github.com/mlaite/pony-build/commit/dbc6e54b65689ca27d71e7c9290ca897e789259a</a><br><br>Still passes all the context tests. Yay :) <br>
<br>Though, I think we may have to change up the tests for the c.run() try/except block a bit to make sure it works as intended. What those changes are? --I am not sure yet, have to formulate my thoughts I guess.<br><br>Ummmm, yup, that is about it for now. <br>
<br>Max<br><br><div class="gmail_quote">On Fri, Apr 23, 2010 at 11:18 PM, C. Titus Brown <span dir="ltr"><<a href="mailto:ctb@msu.edu">ctb@msu.edu</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div class="im">On Fri, Apr 23, 2010 at 01:12:24PM -0400, Max Laite wrote:<br>
> Added some log_error stuff....<br>
><br>
> Also added reslist.append(c.get_results()) to the c.run() try/except. This<br>
> should grab the results for passing to the server properly if exception is<br>
> raised.<br>
><br>
> Added the state of initialized to the client_info dict, so we can see status<br>
> of that on web interface also.<br>
<br>
</div>sounds great - errm, did you push this to github?<br>
<div class="im"><br>
> Then just an extra thought to throw out there....<br>
><br>
> Do we want to provide a higher level of feedback somehow on the web side? Do<br>
> we want to store the log data for reporting if they choose to use -v or<br>
> --debug? To a file to upload?<br>
<br>
</div>Yes, that would be awesome. And I think a good default.<br>
<font color="#888888"><br>
--titus<br>
</font><div><div></div><div class="h5"><br>
> On Thu, Apr 22, 2010 at 4:06 PM, C. Titus Brown <<a href="mailto:ctb@msu.edu">ctb@msu.edu</a>> wrote:<br>
><br>
> > On Thu, Apr 22, 2010 at 03:49:07PM -0400, Max Laite wrote:<br>
> > > env<br>
> > ><br>
> > > Tests:<br>
> > ><br>
> > <a href="http://github.com/mlaite/pony-build/commit/3b3e53d15f0f8a83b927310507c8fb3095d813e9" target="_blank">http://github.com/mlaite/pony-build/commit/3b3e53d15f0f8a83b927310507c8fb3095d813e9</a><br>
> > ><br>
> > > pony_client:<br>
> > ><br>
> > <a href="http://github.com/mlaite/pony-build/commit/150e3e1acab9cc78d13e85d181e3c705520b16a4" target="_blank">http://github.com/mlaite/pony-build/commit/150e3e1acab9cc78d13e85d181e3c705520b16a4</a><br>
> ><br>
> > Hey Max,<br>
> ><br>
> > a couple of comments :)<br>
> ><br>
> > --<br>
> ><br>
> > 'init_status' is not very clear as a flag name goes. Maybe 'initialized'?<br>
> ><br>
> > --<br>
> ><br>
> > How about creating a new context object of type 'Context' if context is<br>
> > None<br>
> > in the 'do' function? 'Context' does a bunch of useful stuff, and it would<br>
> > simplify all of your 'if' statements down to one 'if' at the beginning:<br>
> ><br>
> > if context is None:<br>
> > context = Context()<br>
> ><br>
> > --<br>
> ><br>
> > try/except with blanket 'except' and no reporting, e.g.<br>
> ><br>
> > try:<br>
> > # foo bar baz<br>
> > except:<br>
> > # cleanup with no reporting<br>
> ><br>
> > is a Bad Idea. I see a few problems with your code:<br>
> ><br>
> > - 'success' may still be set to True even if a c.run() call raises an<br>
> > exception.<br>
> ><br>
> > - there's no logging whatsoever; at the very least every 'except' branch<br>
> > should have some sort of log_error call. Right now the excepts will<br>
> > catch everything, including genuine programming errors, silently!<br>
> ><br>
> > --<br>
> ><br>
> > Hmm, that's enough for now...<br>
> ><br>
> > thanks,<br>
> > --titus<br>
> ><br>
<br>
</div></div>--<br>
<div><div></div><div class="h5">C. Titus Brown, <a href="mailto:ctb@msu.edu">ctb@msu.edu</a><br>
</div></div></blockquote></div><br>