I knew it was me. Was not pointing fingers at anyone. (Your repo was just easiest to link to :) )<br><br>git blame >>> Awesome though..... <br><br>Will get right on those instructions El Capitán.<br><br>Thanks,<br>
Max<br><br><div class="gmail_quote">On Mon, Apr 19, 2010 at 7:28 PM, C. Titus Brown <span dir="ltr"><<a href="mailto:ctb@msu.edu">ctb@msu.edu</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div><div></div><div class="h5">On Mon, Apr 19, 2010 at 04:31:15PM -0400, Max Laite wrote:<br>
> Whats going on here?......<br>
><br>
> <a href="http://github.com/ctb/pony-build/blob/master/client/pony_client.py#L191" target="_blank">http://github.com/ctb/pony-build/blob/master/client/pony_client.py#L191</a><br>
><br>
> <a href="http://github.com/ctb/pony-build/blob/master/client/pony_client.py#L200" target="_blank">http://github.com/ctb/pony-build/blob/master/client/pony_client.py#L200</a><br>
><br>
> Hah. Tsk Tsk.....<br>
<br>
</div></div>Dear Max,<br>
<br>
one can only assume you are implying that I messed up the indentation<br>
of those lines. Alas, there is a handy git command called 'git blame'<br>
that will show you who the true culprit is; run it like so:<br>
<br>
git blame client/pony_client.py > foo.txt<br>
<br>
and look at lines 191 and 200 of foo.txt. It will show you the last<br>
person to have committed changes affecting those lines.<br>
<br>
Our collective failure is in not having good tests for this section<br>
of the code (and in fact this has bug has caused some minor problems that I<br>
noticed -- so thanks, good catch!) As both the culprit who screwed up<br>
the indentation, and the person who noticed it, I hereby nominate you to<br>
write some tests! Ain't open source grand?<br>
<br>
Conveniently I've started you down that path by giving you some tests for<br>
other aspects of the context objects in my 'tests_for_max' branch.<br>
<br>
So, please:<br>
<br>
- start a new branch off of my 'master', and merge in 'tests_for_max';<br>
<br>
- write tests that detect this problem, and commit them;<br>
<br>
- fix the problem and verify that the tests now pass;<br>
<br>
- push changes & let me know what branch to merge.<br>
<br>
cheerio,<br>
--titus<br>
<font color="#888888">--<br>
C. Titus Brown, <a href="mailto:ctb@msu.edu">ctb@msu.edu</a><br>
</font></blockquote></div><br>