Yea yea, I know don't use global variables. I am just throwing stuff around, ideas tend to spawn other ideas for me.<br><br>Will mess around with it some more this weekend.<br><br><br><br>Thanks,<br> Max<br><br><div class="gmail_quote">
On Sat, Apr 17, 2010 at 3:06 PM, C. Titus Brown <span dir="ltr"><<a href="mailto:ctb@msu.edu">ctb@msu.edu</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div class="im">On Sat, Apr 17, 2010 at 02:47:36PM -0400, Max Laite wrote:<br>
> The bug, which is cause of missing '=' , should of been fixed in one the<br>
> more recent pushes. Ah, its fixed in my initial stab at context failure<br>
> push.<br>
<br>
</div>OK. I'm having a tough time figuring out what branches of yours to<br>
look to (because of some github UI fail) so please be explicit and<br>
point to not just commits but branches. Communication => good :)<br>
<br>
[ ... ]<br>
<div class="im"><br>
> However.....With Virtualenv we have to catch the error before it even jumps<br>
> into the "for c in commands:" All the Dependencies are done during the<br>
> following call in do()<br>
> if context:<br>
> context.initialize()<br>
<br>
</div>Yes, you have to put error checking there as well as in the for loop.<br>
<div class="im"><br>
> I originally tried doing the break in the for loop but it would never work<br>
> how expected. Putting a failure in the for loop will only take care of build<br>
> command errors (checkout,build,test)<br>
<br>
</div>Exactly, you want to take care of both.<br>
<div class="im"><br>
> This is still with global variable but want through out the general<br>
> idea.....So what if we just put the "for c in commands:" inside an<br>
> if....so....... if not error_state do the for loop.....So then that would<br>
> take out all that redundancy and would skip to all the other steps if the<br>
> test passes....<br>
<br>
</div>Well, you need a try/except in the loop anyway to catch raised exceptions<br>
from build commands, which aren't currently handled...<br>
<br>
Tell ya what -- here are some tests. (branch 'tests_for_max')<br>
<br>
<a href="http://github.com/ctb/pony-build/blob/tests_for_max/client/test_client/test_context.py" target="_blank">http://github.com/ctb/pony-build/blob/tests_for_max/client/test_client/test_context.py</a><br>
<br>
Merge these in to your context failure code and get them all to work<br>
(feel free to change the tests, of course, but there's only one place<br>
where I think you'll need to).<br>
<br>
And, not to threaten, but if you continue to use global variables I will break<br>
your knees or something. Bad Max.<br>
<br>
cheers,<br>
<font color="#888888">--titus<br>
</font></blockquote></div><br>