Ok, so we still want to handle making pip fail though?<br><br>So then, we just want to add in cleanup/exit code within the if ret != 0 block for the required?<br><br><br>----------------<br><br>I was reading up on returncode, that is in use in _run_command....We will have to see but it sounds like when we use poll() to do the timeout stuff, returncode might actually set ret to something other then None (0), so those tests in virtualenvContext may not work as setup with ret !=0 .<br>
<br>I will dig a little more when i am home.<br><br>Max<br><br><br><br><div class="gmail_quote">On Thu, Feb 25, 2010 at 10:06 PM, C. Titus Brown <span dir="ltr"><<a href="mailto:ctb@msu.edu">ctb@msu.edu</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div class="im">On Mon, Feb 22, 2010 at 10:15:02PM -0400, Max Laite wrote:<br>
> Um I probably missed it when i was separating my branches, and maybe Fatima<br>
> pulled my branch before i fixed those.<br>
><br>
> I have not really gotten to doing anything with optional deps. We could do<br>
> something along the lines of when a install fails check to see whether it<br>
> was a required or opt and handle accordingly....Maybe.<br>
><br>
> So you bring in the two lists, combine them for doing the pip install then<br>
> check against the lists for the failed stuff? Probably not the best way, but<br>
> first time I am really thinking about the opt stuff.<br>
<br>
</div>Hey Max, Take a look at what I did and tell me what you think.<br>
<font color="#888888"><br>
--t<br>
</font></blockquote></div><br>