That is why you are the expert, man, once you break the stuff down it seems so simple and clear. I am like herp derp now.<br><br>Thanks,<br> Max<br><br><div class="gmail_quote">On Tue, Feb 23, 2010 at 7:31 PM, C. Titus Brown <span dir="ltr"><<a href="mailto:ctb@msu.edu">ctb@msu.edu</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div class="im">On Tue, Feb 23, 2010 at 07:26:18PM -0400, Max Laite wrote:<br>
> <a href="http://github.com/mlaite/pony-build/blob/subprocess/client/pony_client.py#L93" target="_blank">http://github.com/mlaite/pony-build/blob/subprocess/client/pony_client.py#L93</a><br>
><br>
> In the process of writing a test for this......<br>
<br>
</div>Why not just do a 'time.sleep(timeout)'?<br>
<br>
And note that _run_command needs to return a triple. What happens if<br>
instead of returning None, you just let it fall through to 'communicate'?<br>
<br>
Otherwise I like, thanks!<br>
<br>
You'll probably need to do a merge with my latest master, where I've posted<br>
some changes to _run_command.<br>
<div class="im"><br>
> One thing I need to discuss is, do we split the timeout off to its own<br>
> func?(not sure if its even really possible like that with current setup of<br>
> _run_command) or do we just add timeout argument to all the *Clones so that<br>
> you can specify in build scripts, then when the *Clones call _runPcommand<br>
> they pass timeout like that?<br>
><br>
> Do we do two separate versions of _run_command?<br>
<br>
</div>Hmm. I think it belongs in _run_command, being passed in as a kw arg. Also<br>
have a global TIMEOUT variable in pony_client.py that is overridden if a<br>
timeout is passed into _run_command.<br>
<br>
If 'timeout' is set to None, don't poll at all and just fall through to<br>
communicate().<br>
<br>
Sound good?<br>
<br>
--titus<br>
<font color="#888888">--<br>
C. Titus Brown, <a href="mailto:ctb@msu.edu">ctb@msu.edu</a><br>
</font></blockquote></div><br>