Yes, I will move the .pony-build dir creation to its own function. <br><br>I took the lazy way out at the time, I just ran through a few build scripts, deleting the main cache_dir and the repo dirs after each run to test the different cases.....<br>
<br>Yes, I need to work on standardizing my indents and comments. Have no fear, I will get some consistency by the end of the semester!<br><br>I will look at your script, I need to do some catching up on testing stuff the proper way (easy way?).<br>
<br>I need to do some cleanup now, re: indents, move the cache_dir creation to its own func. Get rid some my debug stuff. Change a couple var names, so they make sense. <br><br><div class="gmail_quote">On Sun, Jan 24, 2010 at 6:51 PM, C. Titus Brown <span dir="ltr"><<a href="mailto:ctb@msu.edu">ctb@msu.edu</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div><div></div><div class="h5">On Sat, Jan 23, 2010 at 08:21:57PM -0400, Max Laite wrote:<br>
> Pushed my work to mkdir branch under my repo. Probably not the prettiest<br>
> code, but it works......Would like to discuss with you tomorrow(Jan. 24) if<br>
> possible.<br>
><br>
> It still has some stuff in it I was using for debugging, but that is what i<br>
> got so far. I am sort of tied to weekends for working on pb with my school<br>
> and work load. Hoping to pick up my pace after i get settled into the<br>
> semester though.<br>
<br>
</div></div>Hi Max, thanks! I've attached the diff of your work for everyone's reference.<br>
<br>
Miscellaneous comments and questions:<br>
<br>
- the code to create the actual cache parent dir, ~/.pony-build/, should<br>
probably be factored out into a separate function in the pony_client<br>
module, because it will be used by a bunch of classes -- including<br>
GitClone, HgCheckout, and SvCheckout.<br>
<br>
- how have you tested this? i.e. what test conditions did you use?<br>
<br>
I wrote a short test script, available in my repo under branch 'mkdir',<br>
'client/test-git':<br>
<br>
<a href="http://github.com/ctb/pony-build/blob/mkdir/client/test-git" target="_blank">http://github.com/ctb/pony-build/blob/mkdir/client/test-git</a><br>
<br>
If you want, you could add some additional scripts or test commands<br>
to test other cases than I did.<br>
<br>
- Check out PEP 8 re code style; in particular, you should be putting<br>
spaces between '#' and your comment. I know, nitpicky...<br>
<br>
<a href="http://www.python.org/dev/peps/pep-0008/" target="_blank">http://www.python.org/dev/peps/pep-0008/</a><br>
<br>
Overall, looks good! Could you outline what additional things you think need to<br>
be done?<br>
<br>
thanks,<br>
--titus<br>
<font color="#888888">--<br>
C. Titus Brown, <a href="mailto:ctb@msu.edu">ctb@msu.edu</a><br>
</font></blockquote></div><br>