[pony-build] pony-client rework

C. Titus Brown ctb at msu.edu
Sat Mar 20 11:30:45 PDT 2010


On Mon, Mar 08, 2010 at 08:15:02PM -0500, Jack Carlson wrote:
> I've still been working on the parser for new build scripts, want to do a bit of cleanup on it tomorrow and then try integrating it into the pony-client script itself in the next few days.  What I've been working on so far is all checked in under my pony-client_rework branch:
> 
> http://github.com/JackCarlson/pony-build/tree/pony-client_rework
> 
> My work is mostly in the added file "clients/testConfigAndBuildParser.py"--those functions form the core of what I'm currently planning on integrating into pony-client.py.  I have two other files added--pony-client.config, which stores default information (such as build servers, etc), and quixote.pb, my test Quixote build script.  quixote.pb is ugly for a reason at the moment, was testing various error conditions, but the gist of it is all there.
> 
> Please take a look at it and offer any thoughts/opinions/etc, or if I'm simply doing it all wrong ;-)

Misc comments --

The reason to keep the *defaults* in pony_client.py is that I'd like to
be able to distribute that one file, eventually.  As soon as you have
config files you have a lot more cognitive load for users to deal with,
and for packagers/distributors to confront.

Have you thought at all about how to chain recipes, e.g. have some reasonable
defaults for Python packages, and then specify overrides?  I can't tell without
getting pretty deeply into your implementation :)

I like the general idea (although I think writing your own parser is
bad for business -- have you considered ConfigParser or JSON for a format?)

How are you planning on proceeding?  Let us know when you've got something
that's clean and ready for extended criticism :)

cheers,
--titus



More information about the pony-build mailing list