[pony-build] pony-build Cache Dir

[Max Laite]

Yes, I will move the .pony-build dir creation to its own function.

I took the lazy way out at the time, I just ran through a few build scripts,
deleting the main cache_dir and the repo dirs after each run to test the
different cases.....

Yes, I need to work on standardizing my indents and comments. Have no fear,
I will get some consistency by the end of the semester!

I will look at your script, I need to do some catching up on testing stuff
the proper way (easy way?).

I need to do some cleanup now, re: indents, move the cache_dir creation to
its own func. Get rid some my debug stuff. Change a couple var names, so
they make sense.

On Sun, Jan 24, 2010 at 6:51 PM, C. Titus Brown <ctb at msu.edu> wrote:

> On Sat, Jan 23, 2010 at 08:21:57PM -0400, Max Laite wrote:
> > Pushed my work to mkdir branch under my repo.  Probably not the prettiest
> > code, but it works......Would like to discuss with you tomorrow(Jan. 24)
> if
> > possible.
> >
> > It still has some stuff in it I was using for debugging, but that is what
> i
> > got so far. I am sort of tied to weekends for working on pb with my
> school
> > and work load. Hoping to pick up my pace after i get settled into the
> > semester though.
>
> Hi Max, thanks! I've attached the diff of your work for everyone's
> reference.
>
> Miscellaneous comments and questions:
>
>  - the code to create the actual cache parent dir, ~/.pony-build/, should
>   probably be factored out into a separate function in the pony_client
>   module, because it will be used by a bunch of classes -- including
>   GitClone, HgCheckout, and SvCheckout.
>
>  - how have you tested this?  i.e. what test conditions did you use?
>
>   I wrote a short test script, available in my repo under branch 'mkdir',
>   'client/test-git':
>
>      http://github.com/ctb/pony-build/blob/mkdir/client/test-git
>
>   If you want, you could add some additional scripts or test commands
>   to test other cases than I did.
>
>  - Check out PEP 8 re code style; in particular, you should be putting
>   spaces between '#' and your comment.  I know, nitpicky...
>
>     http://www.python.org/dev/peps/pep-0008/
>
> Overall, looks good! Could you outline what additional things you think
> need to
> be done?
>
> thanks,
> --titus
> --
> C. Titus Brown, ctb at msu.edu
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.idyll.org/pipermail/pony-build/attachments/20100124/425c30d7/attachment.html>