[pony-build] Merging in progress.

[Max Laite]

Ah, right on.

On Fri, Feb 26, 2010 at 11:14 AM, C. Titus Brown <ctb at msu.edu> wrote:

> On Fri, Feb 26, 2010 at 11:06:43AM -0400, Max Laite wrote:
> > Ok, so we still want to handle making pip fail though?
>
> If pip fails *and* we have necessary stuff to install, then how are we
> going
> to install it?
>
> > So then, we just want to add in cleanup/exit code within the if ret != 0
> > block for the required?
>
> I ...think so?
>
> > I was reading up on returncode, that is in use in _run_command....We will
> > have to see but it sounds like when we use poll() to do the timeout
> stuff,
> > returncode might actually set ret to something other then None (0), so
> those
> > tests in virtualenvContext may not work as setup with ret !=0 .
> >
> > I will dig a little more when i am home.
>
> None != 0.
>
> poll() returning None => subprocess not yet finished.
>
> poll() returning number => subprocess finished
>   poll() returning 0 => subprocess command was successful.
>
> cheers,
> --titus
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.idyll.org/pipermail/pony-build/attachments/20100226/038de4e1/attachment-0001.htm>