[pony-build] Merging in progress.

[Max Laite]

Ok, so we still want to handle making pip fail though?

So then, we just want to add in cleanup/exit code within the if ret != 0
block for the required?


----------------

I was reading up on returncode, that is in use in _run_command....We will
have to see but it sounds like when we use poll() to do the timeout stuff,
returncode might actually set ret to something other then None (0), so those
tests in virtualenvContext may not work as setup with ret !=0 .

I will dig a little more when i am home.

Max



On Thu, Feb 25, 2010 at 10:06 PM, C. Titus Brown <ctb at msu.edu> wrote:

> On Mon, Feb 22, 2010 at 10:15:02PM -0400, Max Laite wrote:
> > Um I probably missed it when i was separating my branches, and maybe
> Fatima
> > pulled my branch before i fixed those.
> >
> > I have not really gotten to doing anything with optional deps. We could
> do
> > something along the lines of when a install fails check to see whether it
> > was a required or opt and handle accordingly....Maybe.
> >
> > So you bring in the two lists, combine them for doing the pip install
> then
> > check against the lists for the failed stuff? Probably not the best way,
> but
> > first time I am really thinking about the opt stuff.
>
> Hey Max, Take a look at what I did and tell me what you think.
>
> --t
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.idyll.org/pipermail/pony-build/attachments/20100226/ca579e6d/attachment.htm>