[pony-build] Context Failures

[Max Laite]

Some more stuff....

http://github.com/mlaite/pony-build/commit/e70bab1127ee90383f0db00a9d50f804c0c807b5

On Tue, Apr 27, 2010 at 5:29 PM, Max Laite <mlaite at gmail.com> wrote:

> Here you go, forgot to push other day after commit, then forgot to email
> after push.
>
>
> http://github.com/mlaite/pony-build/commit/3dade44fde3f6bd5011898d18e85a3f224771d7c
>
>
> On Sun, Apr 25, 2010 at 10:00 PM, C. Titus Brown <ctb at msu.edu> wrote:
>
>> would there be an associated push?
>>
>> On Sun, Apr 25, 2010 at 09:54:10PM -0400, Max Laite wrote:
>> > Ah, try/finally worked out pretty good. I will get this stuff figured
>> out
>> > eventually, or maybe not. haha
>> >
>> > Will look at the redundant success loop and push some more changes
>> sometime
>> > this week.
>> >
>> > May be a little slow though next couple weeks, got end semester stuff
>> and
>> > carnival.
>> >
>> > Thanks!
>> >
>> > Max
>> >
>> > On Sun, Apr 25, 2010 at 9:20 PM, C. Titus Brown <ctb at msu.edu> wrote:
>> >
>> > > On Sat, Apr 24, 2010 at 08:27:02PM -0400, Max Laite wrote:
>> > > > Whoops, guess I did not.
>> > > >
>> > > >
>> > >
>> http://github.com/mlaite/pony-build/commit/dbc6e54b65689ca27d71e7c9290ca897e789259a
>> > > >
>> > > > Still passes all the context tests. Yay :)
>> > > >
>> > > > Though, I think we may have to change up the tests for the c.run()
>> > > > try/except block a bit to make sure it works as intended. What those
>> > > changes
>> > > > are? --I am not sure yet, have to formulate my thoughts I guess.
>> > > >
>> > > > Ummmm, yup, that is about it for now.
>> > >
>> > > Cool -- let me know when you figure out what changes you want to make
>> :).
>> > > Looks good, thanks!
>> > >
>> > > I also wanted to point out a few things:
>> > >
>> > > around
>> > >
>> http://github.com/mlaite/pony-build/blob/env/client/pony_client.py#L813,
>> > >
>> > > you're violating "Don't Repeat Yourself (DRY)" --
>> context.end_command() and
>> > > reslist.append are called both within and without the 'except' (and
>> > > incidentally, in different orders.  tsk tsk.).  I think with a teensy
>> bit
>> > > of refactoring and judicious use of 'try/finally', you could make this
>> > > a bit shorter and a lot neater.
>> > >
>> > > Note that the 'success' for loop (line 829 onwards) is pretty
>> redundant;
>> > > you can do that same logic within the main command loop, I think.
>> > >
>> > > Whaddya say?
>> > >
>> > > thanks,
>> > > --titus
>> > >
>>
>> > _______________________________________________
>> > pony-build mailing list
>> > pony-build at lists.idyll.org
>> > http://lists.idyll.org/listinfo/pony-build
>>
>>
>> --
>> C. Titus Brown, ctb at msu.edu
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.idyll.org/pipermail/pony-build/attachments/20100428/d04ffaf0/attachment.htm>