[pony-build] Indentation.....Serious Business

Max Laite mlaite at gmail.com
Mon Apr 19 18:36:47 PDT 2010


I knew it was me. Was not pointing fingers at anyone. (Your repo was just
easiest to link to :) )

git blame >>> Awesome though.....

Will get right on those instructions El Capitán.

Thanks,
  Max

On Mon, Apr 19, 2010 at 7:28 PM, C. Titus Brown <ctb at msu.edu> wrote:

> On Mon, Apr 19, 2010 at 04:31:15PM -0400, Max Laite wrote:
> > Whats going on here?......
> >
> > http://github.com/ctb/pony-build/blob/master/client/pony_client.py#L191
> >
> > http://github.com/ctb/pony-build/blob/master/client/pony_client.py#L200
> >
> > Hah. Tsk Tsk.....
>
> Dear Max,
>
> one can only assume you are implying that I messed up the indentation
> of those lines.  Alas, there is a handy git command called 'git blame'
> that will show you who the true culprit is; run it like so:
>
>        git blame client/pony_client.py > foo.txt
>
> and look at lines 191 and 200 of foo.txt.  It will show you the last
> person to have committed changes affecting those lines.
>
> Our collective failure is in not having good tests for this section
> of the code (and in fact this has bug has caused some minor problems that I
> noticed -- so thanks, good catch!)  As both the culprit who screwed up
> the indentation, and the person who noticed it, I hereby nominate you to
> write some tests!  Ain't open source grand?
>
> Conveniently I've started you down that path by giving you some tests for
> other aspects of the context objects in my 'tests_for_max' branch.
>
> So, please:
>
>  - start a new branch off of my 'master', and merge in 'tests_for_max';
>
>  - write tests that detect this problem, and commit them;
>
>  - fix the problem and verify that the tests now pass;
>
>  - push changes & let me know what branch to merge.
>
> cheerio,
> --titus
> --
> C. Titus Brown, ctb at msu.edu
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.idyll.org/pipermail/pony-build/attachments/20100419/ad14599c/attachment.htm>


More information about the pony-build mailing list