[pony-build] Test Fixed

[C. Titus Brown]

On Wed, Apr 07, 2010 at 09:50:38PM -0500, Fatima Cherkaoui wrote:
> I have created a new branch as advised called f_master . I fixed the hg_test
> and pushed it to the same branch:
> 
> http://github.com/cherkf/pony-build/blob/f_master/client/test_client/test_hg_client.py
> 
> Could you take a look at it and advise what I should work on next.

Hi Fatima,

I grabbed it, merged in all of my changes, and ran the tests -- so far
so good!  Please grab my updated master branch and make changes to that;
you should be able to do a 'pull' into your f_master branch, if you like.

Comments:

--

On line 97 of test_hg_client,

http://github.com/cherkf/pony-build/blob/f_master/client/test_client/test_hg_client.py#L97

you should change the URL so that it's not hardcoded.

There are also some lines commented out in here that should just be removed
('commands.getoutput', etc.)

--

I don't see how this is actually testing the 'branch' argument to HgClone,
though, since you don't ever call HgClone with branch set to anything
other than default.  Could you remind me of your ultimate decision on things?

If allowing multiple branches in HgClone doesn't make sense, then please
go ahead and refactor HgClone so that all of that code is removed.

If it *does* make sense, then your tests should test it :)

--

Should I also look at your 'mkdir' branch?

thanks,
--titus
-- 
C. Titus Brown, ctb at msu.edu