[pony-build] Context Failures

[Max Laite]

Yea yea, I know don't use global variables. I am just throwing stuff around,
ideas tend to spawn other ideas for me.

Will mess around with it some more this weekend.



Thanks,
  Max

On Sat, Apr 17, 2010 at 3:06 PM, C. Titus Brown <ctb at msu.edu> wrote:

> On Sat, Apr 17, 2010 at 02:47:36PM -0400, Max Laite wrote:
> > The bug, which is cause of missing '=' , should of been fixed in one the
> > more recent pushes. Ah, its fixed in my initial stab at context failure
> > push.
>
> OK.  I'm having a tough time figuring out what branches of yours to
> look to (because of some github UI fail) so please be explicit and
> point to not just commits but branches.  Communication => good :)
>
> [ ... ]
>
> > However.....With Virtualenv we have to catch the error before it even
> jumps
> > into the "for c in commands:" All the Dependencies are done during the
> > following call in do()
> > if context:
> >         context.initialize()
>
> Yes, you have to put error checking there as well as in the for loop.
>
> > I originally tried doing the break in the for loop but it would never
> work
> > how expected. Putting a failure in the for loop will only take care of
> build
> > command errors (checkout,build,test)
>
> Exactly, you want to take care of both.
>
> > This is still with global variable but want through out the general
> > idea.....So what if we just put the "for c in commands:" inside an
> > if....so....... if not error_state do the for loop.....So then that would
> > take out all that redundancy and would skip to all the other steps if the
> > test passes....
>
> Well, you need a try/except in the loop anyway to catch raised exceptions
> from build commands, which aren't currently handled...
>
> Tell ya what -- here are some tests.  (branch 'tests_for_max')
>
>
> http://github.com/ctb/pony-build/blob/tests_for_max/client/test_client/test_context.py
>
> Merge these in to your context failure code and get them all to work
> (feel free to change the tests, of course, but there's only one place
> where I think you'll need to).
>
> And, not to threaten, but if you continue to use global variables I will
> break
> your knees or something.  Bad Max.
>
> cheers,
> --titus
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.idyll.org/pipermail/pony-build/attachments/20100417/5894a62a/attachment.htm>