[pony-build] status rep, please

[C. Titus Brown]

On Mon, Mar 29, 2010 at 04:48:19PM -0500, Fatima Cherkaoui wrote:
> Hello,
> 
> This week I have been working on writing tests for the hg branches. I got a
> little confused about the way mercurial clones and tried a different
> approach. I have also changed the test but it still failing.
> 
> If you could take a look at what i did and let me know if you have any
> remarks/suggestions
>  http://cherkf.wordpress.com/
> 
> HgClone: http://github.com/cherkf/pony-build/blob/mkdir/client/pony_client.py
> 
> Test:
> http://github.com/cherkf/pony-build/blob/mkdir/client/test_client/test_hg_client.py

Hi Fatima,

the blog posts look great and really explain things well -- nice job!

I pulled down your 'mkdir' branch and merged with my master; the result
is in my repo, branch 'f_mkdir'.

Two client tests fail for me at 'assert branch == "default"' in test_hg_client.

You modified a lot of whitespace in the files (try grabbing my latest
branch as 'titus_master', and then doing 'git diff titus_master' to see
what I mean).  In general, you should work to minimize the "random"
changes that aren't functionally; if you feel they're important, then
sequester them in another branch so that I can evaluate them separately.

Finally, I'm confused about what

	HgClone(self.repository, '-r', 7)

does in the tests -- it doesn't look like my HgClone __init__ method
signature matches.  I think I must be missing the right pony_client?
In any case, shouldn't the command be

	HgClone(self.repository, branch='7')

?

thanks,
--titus