[cse491] few questions

[Steve Wakeford]

Yes it matters because if we forget about just passing the tests for a 
minute, the original implies that you are calling the server class 
constructor with a port (integer) and an app and the second implies a 
hostname (string) and an app. Consistency would be favorable, no?

Note that yes, if I do hard code this as Amenta suggested all of the 
tests pass, thanks to both Joes for assistance.

Joseph Blossom wrote:
> Does it even really matter? serve_forever is never being called by the 
> tests, and therefore the port doesn't really matter at all.  In 
> run_fake_socket we can see:
> server = webserve_nb.NonblockingServer('', hello_app)
>
> done, data = server.handle_connection(sock)
> He's not doing anything over any sort of a network in the tests, but 
> rather creating fake sockets which emulate what a real socket would 
> do. Hence:
>
> class fake_nb_client_sock_obj(fake_client_sock_obj):
> Mine does nothing with the port '', and passes the tests fine. I suppose you could for the sake of bad input, but to get your code to work with his tests, nothing extra is needed.
> The other Joe
>
>
> On Wed, Oct 28, 2009 at 9:07 PM, Steve Wakeford <wakeford at msu.edu 
> <mailto:wakeford at msu.edu>> wrote:
>
>     I am a little stumped as to why the Blocking server is
>     instantiated in the hw7 tests with
>
>     server = webserve.Server(8000, app)
>
>     but the Non-blocking server is instantiated with
>
>     server = webserve_nb.NonblockingServer('', hello_app)
>
>     Notice the first argument is an integer in the former and a string
>     in the latter. Is it just me or am I missing something? How do we
>     deal with this (for non-blocking) since the port should be
>     dynamically passed in upon instantiation from a command line argument?
>
>     My goal is to subclass the Blocking server and only to override
>     its __init__() and serve_forever() methods. Any ideas?
>
>     Thanks,
>     -Steve
>
>     _______________________________________________
>     cse491-fall-2009 mailing list
>     cse491-fall-2009 at lists.idyll.org
>     <mailto:cse491-fall-2009 at lists.idyll.org>
>     http://lists.idyll.org/listinfo/cse491-fall-2009
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.idyll.org/pipermail/cse491-fall-2009/attachments/20091028/3b5ae268/attachment.htm>